Skip to content

Improve confirm modal copy across the board#3205

Merged
david-crespo merged 6 commits intomainfrom
resource-kind-labels
May 5, 2026
Merged

Improve confirm modal copy across the board#3205
david-crespo merged 6 commits intomainfrom
resource-kind-labels

Conversation

@david-crespo
Copy link
Copy Markdown
Collaborator

@david-crespo david-crespo commented Apr 30, 2026

  • Require resource kind so there are no weird "Confirm delete" without a resource
  • Reword all confirm modals: "Confirm delete snapshot" -> "Delete snapshot", "Confirm unlink pool" -> "Unlink pool", etc.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
console Ready Ready Preview May 5, 2026 0:37am

Request Review

@david-crespo david-crespo force-pushed the resource-kind-labels branch from 0210fa7 to eeecf13 Compare April 30, 2026 23:04
@david-crespo david-crespo marked this pull request as draft May 1, 2026 03:06
@david-crespo david-crespo marked this pull request as ready for review May 1, 2026 03:06
@david-crespo david-crespo marked this pull request as draft May 1, 2026 03:06
@david-crespo david-crespo marked this pull request as ready for review May 1, 2026 03:06
@david-crespo david-crespo marked this pull request as draft May 1, 2026 03:06
@david-crespo david-crespo marked this pull request as ready for review May 1, 2026 03:06
@david-crespo david-crespo marked this pull request as draft May 1, 2026 03:06
@david-crespo
Copy link
Copy Markdown
Collaborator Author

Lol at the status changes. See kitlangton/ghui#4

@david-crespo david-crespo marked this pull request as ready for review May 1, 2026 15:27
Copy link
Copy Markdown
Contributor

@charliepark charliepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe prefer Confirm ${resourceKind} deletion over Confirm delete ${resourceKind}, but not a blocker.

@david-crespo
Copy link
Copy Markdown
Collaborator Author

I think you’re right that there’s something grammatically funny about “Confirm delete snapshot” but I don’t like the passive “deletion” either. Maybe “Delete snapshot” or “Delete snapshot?”

@charliepark
Copy link
Copy Markdown
Contributor

Yeah, that's shorter and snappier. I think either with or without the question mark works. Maybe a slight tilt towards no question mark, since the body copy in the modal already has the question mark, but I'm good with either.

@david-crespo
Copy link
Copy Markdown
Collaborator Author

david-crespo commented May 4, 2026

I like it! I'm making resourceKind required so they all have it.

image

@david-crespo david-crespo changed the title Require resourceKind on confirmDelete Improve confirm modal copy across the board May 5, 2026
@david-crespo
Copy link
Copy Markdown
Collaborator Author

image

@david-crespo david-crespo enabled auto-merge (squash) May 5, 2026 00:37
@david-crespo david-crespo merged commit 8013fcb into main May 5, 2026
7 checks passed
@david-crespo david-crespo deleted the resource-kind-labels branch May 5, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants