Add tabs to access pages #2983
Open
Add tabs to access pages #2983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
I wonder if, since we show |
Contributor
Author
|
Here's the modal that shows the list of group members: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the Silo Access and Project Access pages into tabs, so a viewer can see the roles broken down, showing just Users, just Groups, or All with access (and their respective roles). This also updates the forms on each tab's page, to show just "Add user", "Add group", or "Add user or group", depending on what tab it's shown on.
This is part of #2887, and will be useful for more detailed views of group member counts, user
time_modifiedvalues (as in oxidecomputer/omicron#9494), more comprehensive lists of users, etc. I wanted to get these changes in first, though, to keep future PRs tighter.The forms are slightly modified to make them more contextually-relevant as well. (Ignore the weird scaling difference due to the screenshot dimensions.)