Better error for admin group name misconfig #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
no-groups-error
branch
from
41fb193 to
e7228e7
Compare
david-crespo
force-pushed
the
no-groups-error
branch
from
e7228e7 to
318bc68
Compare
david-crespo
force-pushed
the
no-groups-error
branch
from
318bc68 to
52c1674
Compare
david-crespo
force-pushed
the
no-groups-error
branch
from
52c1674 to
7020389
Compare
david-crespo
changed the title
charliepark
reviewed
Feb 2, 2025
app/components/ErrorBoundary.tsx
Outdated
| You are not in any user groups and you have no assigned role on the silo. This | ||
| usually means the{' '} | ||
| <a | ||
| href="https://docs.oxide.computer/guides/system/completing-rack-config#_test_user_login" |
There was a problem hiding this comment.
Doesn't need to be in https://github.com/oxidecomputer/console/blob/main/app/util/links.ts. Just noting that we do have a bunch of docs.oxide.computer links there, in case we want to continue consolidating them there.
charliepark
reviewed
Feb 2, 2025
Comment on lines
+42
to
+45
| // fetchQuery instead of prefetchQuery means errors blow up here instead of | ||
| // waiting to hit the invariant in the useQuery call. We may end up doing this | ||
| // everywhere, but here in particular it is needed to trigger the silo group | ||
| // misconfig detection case in ErrorBoundary. |
There was a problem hiding this comment.
this is helpful; thank you
charliepark
approved these changes
Feb 2, 2025
david-crespo
force-pushed
the
no-groups-error
branch
from
04910eb to
fab7a1f
Compare
david-crespo
force-pushed
the
no-groups-error
branch
from
fab7a1f to
f30d2e9
Compare
|
Amazing (derogatory). It went back to flaking for the original reason, image upload cancel and retry in chrome. |
david-crespo
force-pushed
the
no-groups-error
branch
from
27b7f5c to
8de7e8c
Compare
david-crespo
force-pushed
the
no-groups-error
branch
from
8de7e8c to
28abda9
Compare
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 6, 2025
oxidecomputer/console@288f1c1...517353e * [517353ee](oxidecomputer/console@517353ee) bump vite and vitest (vitest CVE) * [a6319fc8](oxidecomputer/console@a6319fc8) oxidecomputer/console#2671 * [5bd61e67](oxidecomputer/console@5bd61e67) oxidecomputer/console#2674 * [4646ad47](oxidecomputer/console@4646ad47) minor: console.log -> console.info in api-diff * [7723212c](oxidecomputer/console@7723212c) log before and after file paths in api-diff * [7cde843f](oxidecomputer/console@7cde843f) minor: deleted temp dir problem in bump-omicron.ts
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Feb 6, 2025
oxidecomputer/console@288f1c1...517353e * [517353ee](oxidecomputer/console@517353ee) bump vite and vitest (vitest CVE) * [a6319fc8](oxidecomputer/console@a6319fc8) oxidecomputer/console#2671 * [5bd61e67](oxidecomputer/console@5bd61e67) oxidecomputer/console#2674 * [4646ad47](oxidecomputer/console@4646ad47) minor: console.log -> console.info in api-diff * [7723212c](oxidecomputer/console@7723212c) log before and after file paths in api-diff * [7cde843f](oxidecomputer/console@7cde843f) minor: deleted temp dir problem in bump-omicron.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2573
Obviously the copy could be shorter, but in theory this error should only show up to operators immediately after IdP setup and virtually never again.
Doc link goes to: https://docs.oxide.computer/guides/operator/faq#_how_do_i_fix_the_something_went_wrong_error, which is added in v13, so it won't work until that's merged.