Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance auto restart #2644

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Instance auto restart #2644

wants to merge 15 commits into from

Conversation

benjaminleonard
Copy link
Contributor

@benjaminleonard benjaminleonard commented Jan 9, 2025 •
edited
Loading

Fixes #2469

CleanShot 2025-01-09 at 12 03 09

  • Validate conditional rendering is correct
  • Automatically set autoRestartEnabled to match actual API behaviour
  • Add icon to design system
  • Write docs text
  • Add settings items help text
  • Show last auto restarted?

I'm sure someone will talk me down from the slow spinning icon when auto restart is enabled.

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Jan 21, 2025 10:43am

hawkw
hawkw reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks lovely! I'm not particularly qualified to review the implementation of the frontend code, but I left a couple very minor suggestions on the text we display in the UI. Thanks for all your work on getting this exposed in the console, it looks great!

app/pages/project/instances/instance/tabs/SettingsTab.tsx Outdated Show resolved Hide resolved
app/pages/project/instances/instance/tabs/SettingsTab.tsx Outdated Show resolved Hide resolved
@benjaminleonard benjaminleonard marked this pull request as ready for review January 14, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-crespo david-crespo david-crespo left review comments

@hawkw hawkw hawkw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose instance auto-restart status in the console
3 participants
@benjaminleonard @hawkw @david-crespo