Skip to content

refactor(ast): move AstBuilder type definition #11238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented May 22, 2025

Pure refactor. Move the type definition out of generated file and define it statically instead. We can now change AstBuilder without having to alter the codegen.

Copy link
Contributor Author

overlookmotel commented May 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 22, 2025
Copy link

codspeed-hq bot commented May 23, 2025

CodSpeed Instrumentation Performance Report

Merging #11238 will degrade performances by 12.93%

Comparing 05-23-refactor_ast_move_astbuilder_type_definition (f05c506) with 05-21-feat_syntax_introduce_commentnodeid_ (c2c0268)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.5 ms -12.93%

@overlookmotel overlookmotel marked this pull request as ready for review May 23, 2025 00:03
@graphite-app graphite-app bot force-pushed the 05-21-feat_syntax_introduce_commentnodeid_ branch 2 times, most recently from 6bedcef to ed5c98c Compare May 23, 2025 06:57
@graphite-app graphite-app bot force-pushed the 05-23-refactor_ast_move_astbuilder_type_definition branch from 03d932a to 0b759f3 Compare May 23, 2025 06:57
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 24, 2025
Copy link
Member

Boshen commented May 24, 2025

Merge activity

Pure refactor. Move the type definition out of generated file and define it statically instead. We can now change `AstBuilder` without having to alter the codegen.
@graphite-app graphite-app bot force-pushed the 05-21-feat_syntax_introduce_commentnodeid_ branch from ed5c98c to c2c0268 Compare May 24, 2025 02:44
@graphite-app graphite-app bot force-pushed the 05-23-refactor_ast_move_astbuilder_type_definition branch from 0b759f3 to f05c506 Compare May 24, 2025 02:45
Base automatically changed from 05-21-feat_syntax_introduce_commentnodeid_ to main May 24, 2025 02:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 24, 2025
@graphite-app graphite-app bot merged commit f05c506 into main May 24, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-23-refactor_ast_move_astbuilder_type_definition branch May 24, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants