-
-
Notifications
You must be signed in to change notification settings - Fork 631
perf(allocator/vec): Vec::extend_desugared
set len
only at end
#11082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
overlookmotel
wants to merge
1
commit into
graphite-base/11082
Choose a base branch
from
05-16-perf_allocator_vec_vec_extend_desugared_set_len_only_at_end
base: graphite-base/11082
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
perf(allocator/vec): Vec::extend_desugared
set len
only at end
#11082
overlookmotel
wants to merge
1
commit into
graphite-base/11082
from
05-16-perf_allocator_vec_vec_extend_desugared_set_len_only_at_end
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2025
Merged
CodSpeed Instrumentation Performance ReportMerging #11082 will not alter performanceComparing Summary
|
09d8ddc
to
6c1f6e3
Compare
43a935e
to
0b7da6b
Compare
6c1f6e3
to
52f5c1e
Compare
0b7da6b
to
2798717
Compare
52f5c1e
to
199504c
Compare
29d7d91
to
99ad11f
Compare
199504c
to
c325291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-performance
Category - Solution not expected to change functional behavior, only performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve efficiency of
Vec::extend_desugared
by settinglen
only at the end.std library has to set
len
on each turn of the loop, because it needs to drop all elements added so far in case of a panic. But ourVec<'a, T>
requires thatT
is notDrop
, so we don't have that restriction.I'm not sure if this will make any difference. Making a PR to see what Codspeed says.