Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Update expected to failure based on correct issue #7211

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Sep 5, 2023

Description

Since this issue #4393 was closed so that needs to be updated according to this issue linke for it. #4393 (comment). But New issue is created according to the actual behavior since the expected behavior is unknown. So This PR updates the expected to failure with the new issue created for the same failing test.

Related Issue:

#4393 (comment)

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait till decision from dev team

@SagarGi SagarGi force-pushed the adjust_expec_failure_based_on_Issue branch from 54b49c2 to b47366d Compare September 5, 2023 06:13
@SagarGi SagarGi force-pushed the adjust_expec_failure_based_on_Issue branch 2 times, most recently from 9ea846d to 8cdc362 Compare September 12, 2023 09:14
@SagarGi
Copy link
Member Author

SagarGi commented Sep 12, 2023

This PR is put on hold since this issue is being looked by the development team. So this PR can be waited till some notice from them.

@SwikritiT SwikritiT force-pushed the adjust_expec_failure_based_on_Issue branch from 8cdc362 to 41218a0 Compare September 15, 2023 03:57
@SwikritiT
Copy link
Contributor

let's merge this PR. as this is not adding new test but updating the issue only. The test will probably be removed in the PR where the bug is fixed

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT merged commit 105bf6f into master Sep 15, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the adjust_expec_failure_based_on_Issue branch September 15, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants