Skip to content

fix(l10n): correct zh-Hans Favorite and unify Mongolian note terminology - #559

Merged
kw-tmueller merged 2 commits into
masterfrom
fix/l10n-zh-hans-mn-terminology
Jul 27, 2026
Merged

fix(l10n): correct zh-Hans Favorite and unify Mongolian note terminology#559
kw-tmueller merged 2 commits into
masterfrom
fix/l10n-zh-hans-mn-terminology

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Member

Fixes two pre-existing translation issues surfaced while reviewing the 2.2.0 l10n backfill (#555). Both exist on master today and are independent of that release.

Changes

  • zh-Hans (Simplified Chinese)Favorite was 我的最愛, which is written in Traditional characters (愛/最愛; Simplified is 爱/最爱) and phrased as a noun ("My Favorites") rather than the verb/label sense. Changed to 收藏, the standard Simplified verb form, matching what zh_CN already uses. (The Traditional locales zh_HK/zh_TW correctly keep 我的最愛.)
  • mn (Mongolian) — the note strings mixed two different lexemes: Тэмдэглэгээ ("marking/annotation") for Notes / New note / Delete note, versus Тэмдэглэл ("note/memo") used for the newer strings. Standardised on Тэмдэглэл (Тэмдэглэлүүд for the plural Notes title), the accurate term for a note.

Each language's .js and .json pair is kept in sync; JSON validated.

Notes

  • Verified via native-level review that these are genuine correctness issues, not stylistic preferences.
  • Scoped intentionally small — no other catalogs touched.

🤖 Generated with Claude Code

Two pre-existing translation issues, independent of the 2.2.0 backfill:

- zh-Hans (Simplified Chinese): "Favorite" was "我的最愛" — Traditional
  characters (愛/最愛) and a noun phrase ("My Favorites"). Use "收藏",
  the Simplified verb form, matching zh_CN.
- mn (Mongolian): the note strings mixed two lexemes — "Тэмдэглэгээ"
  (marking/annotation) for Notes/New note/Delete note vs "Тэмдэглэл"
  (note/memo) elsewhere. Standardise on "Тэмдэглэл" ("Тэмдэглэлүүд" for
  the plural "Notes" title), the accurate term for a note.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 requested a review from a team as a code owner July 26, 2026 12:05

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a struggle, because I have no clue if these are really improvements to these translations. We need to find a real person who is fluent in writing these languages. How do we do that?

@DeepDiver1975

Copy link
Copy Markdown
Member Author

This is a struggle, because I have no clue if these are really improvements to these translations.

same apples to transifex - we trust translations done there ....

@phil-davis

Copy link
Copy Markdown
Contributor

same apples to transifex - we trust translations done there

because we think that there are real people with experience in the language doing those translations, and that some other person with the needed language skills has reviewed and approved the translation. So, in the past, we accepted Transifex changes straight into the system (no review of a PR needed). Of course, there might be people on Transifex who are not actually fluent in the language(s) that they claim!

If a new policy is that we accept translations proposed by some "agent", then "the system" should be configured so that those changes are auto-approved in some way (by some bot, like what renovate-bot does). It seems pointless for some real person, who happens to have no expertise in that language, to click "Approve".

新筆記 uses Traditional characters (筆/記); the Simplified forms are 笔/记.
Aligned to 新建笔记 to match the existing zh_CN catalog, completing the same
Traditional→Simplified cleanup this branch already applied to Favorite.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975

Copy link
Copy Markdown
Member Author

Reviewed and verified — approving.

Confirmed against the checkout:

  • zh_CN reference match: zh_CN.js uses 收藏, so zh-Hans now aligns with its sibling Simplified locale.
  • Traditional locales untouched: zh_HK.js/zh_TW.js correctly retain 我的最愛.
  • JSON valid and .js/.json pairs in sync for both locales.
  • No stragglers: no remaining Тэмдэглэгээ in mn.js.

One thing worth calling out explicitly: the zh-Hans New note change (新筆記新建笔记) is a genuine correctness fix, not just phrasing — 筆記 is a Traditional character form living in a Simplified catalog (Simplified is 笔记). Good catch beyond the Favorite fix.

Note: since the Transifex sync is no longer active, there's no risk of these manual corrections being overwritten on a future backfill — so no upstream follow-up is needed here.

Verdict: Approve. Small, correct, and well-scoped.

@kw-tmueller
kw-tmueller merged commit f35ce56 into master Jul 27, 2026
12 checks passed
@kw-tmueller
kw-tmueller deleted the fix/l10n-zh-hans-mn-terminology branch July 27, 2026 09:30
DeepDiver1975 added a commit that referenced this pull request Jul 27, 2026
Since the version bump was authored, several user-facing PRs merged to
master that will ship inside 2.2.0. Record them in the release notes:
full translation backfill (#561), fenced-code-block background (#560),
zh-Hans/Mongolian corrections (#559), duplicate de/de_DE key removal
(#562), and the Transifex-sync retirement (#558).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis pushed a commit that referenced this pull request Jul 27, 2026
* chore: bump version to 2.2.0

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

* docs(changelog): cover l10n and CSS changes shipping in 2.2.0

Since the version bump was authored, several user-facing PRs merged to
master that will ship inside 2.2.0. Record them in the release notes:
full translation backfill (#561), fenced-code-block background (#560),
zh-Hans/Mongolian corrections (#559), duplicate de/de_DE key removal
(#562), and the Transifex-sync retirement (#558).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>

---------

Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants