fix(l10n): correct zh-Hans Favorite and unify Mongolian note terminology - #559
Conversation
Two pre-existing translation issues, independent of the 2.2.0 backfill:
- zh-Hans (Simplified Chinese): "Favorite" was "我的最愛" — Traditional
characters (愛/最愛) and a noun phrase ("My Favorites"). Use "收藏",
the Simplified verb form, matching zh_CN.
- mn (Mongolian): the note strings mixed two lexemes — "Тэмдэглэгээ"
(marking/annotation) for Notes/New note/Delete note vs "Тэмдэглэл"
(note/memo) elsewhere. Standardise on "Тэмдэглэл" ("Тэмдэглэлүүд" for
the plural "Notes" title), the accurate term for a note.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
left a comment
There was a problem hiding this comment.
This is a struggle, because I have no clue if these are really improvements to these translations. We need to find a real person who is fluent in writing these languages. How do we do that?
same apples to transifex - we trust translations done there .... |
because we think that there are real people with experience in the language doing those translations, and that some other person with the needed language skills has reviewed and approved the translation. So, in the past, we accepted Transifex changes straight into the system (no review of a PR needed). Of course, there might be people on Transifex who are not actually fluent in the language(s) that they claim! If a new policy is that we accept translations proposed by some "agent", then "the system" should be configured so that those changes are auto-approved in some way (by some bot, like what renovate-bot does). It seems pointless for some real person, who happens to have no expertise in that language, to click "Approve". |
新筆記 uses Traditional characters (筆/記); the Simplified forms are 笔/记. Aligned to 新建笔记 to match the existing zh_CN catalog, completing the same Traditional→Simplified cleanup this branch already applied to Favorite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
|
Reviewed and verified — approving. Confirmed against the checkout:
One thing worth calling out explicitly: the zh-Hans Note: since the Transifex sync is no longer active, there's no risk of these manual corrections being overwritten on a future backfill — so no upstream follow-up is needed here. Verdict: Approve. Small, correct, and well-scoped. |
Since the version bump was authored, several user-facing PRs merged to master that will ship inside 2.2.0. Record them in the release notes: full translation backfill (#561), fenced-code-block background (#560), zh-Hans/Mongolian corrections (#559), duplicate de/de_DE key removal (#562), and the Transifex-sync retirement (#558). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
* chore: bump version to 2.2.0 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> * docs(changelog): cover l10n and CSS changes shipping in 2.2.0 Since the version bump was authored, several user-facing PRs merged to master that will ship inside 2.2.0. Record them in the release notes: full translation backfill (#561), fenced-code-block background (#560), zh-Hans/Mongolian corrections (#559), duplicate de/de_DE key removal (#562), and the Transifex-sync retirement (#558). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> --------- Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Fixes two pre-existing translation issues surfaced while reviewing the 2.2.0 l10n backfill (#555). Both exist on
mastertoday and are independent of that release.Changes
Favoritewas我的最愛, which is written in Traditional characters (愛/最愛; Simplified is 爱/最爱) and phrased as a noun ("My Favorites") rather than the verb/label sense. Changed to收藏, the standard Simplified verb form, matching whatzh_CNalready uses. (The Traditional localeszh_HK/zh_TWcorrectly keep我的最愛.)Тэмдэглэгээ("marking/annotation") for Notes / New note / Delete note, versusТэмдэглэл("note/memo") used for the newer strings. Standardised onТэмдэглэл(Тэмдэглэлүүдfor the plural Notes title), the accurate term for a note.Each language's
.jsand.jsonpair is kept in sync; JSON validated.Notes
🤖 Generated with Claude Code