fixes #439: Added styles for code-block#440
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
1 similar comment
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: Konstantin Gorodinskii <mail@konstantin.io>
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -1,4 +1,2 @@ | |||
| <div id="app-navigation-toggle" class="icon-menu" style="display:none;"></div> | |||
| <pre editor notes-timeout-change="save()" notes-autofocus class="editor" ng-class="{saving: isSaving()}">{{note.content}}</pre> | |||
There was a problem hiding this comment.
This change fixes #369. I'm very interested to see it merged @DeepDiver1975 @jnweiger
dj4oC
left a comment
dj4oC
left a comment
There was a problem hiding this comment.
- Security: None found.
- Stability: Title says "styles for code-block" but the diff is much broader: adds a notes-search feature (
noteFilter.js, controller changes, new markup intemplates/main.php), a PWAmanifest.json,.gitignoreentries for build artifacts, and — notably — removes the<div id="app-navigation-toggle">wrapper (both its opening and closing tag) fromtemplates/note.php. That structural DOM removal isn't explained by the PR's stated intent and could affect layout/nav-toggle behavior elsewhere in the app; it needs explicit justification and manual UI verification before merge. - Performance: N/A.
- Test coverage: No tests added for the new search/filter logic (
noteFilter.js, the debounced search handlers innotescontroller.js). - TODOs found: 0
- Dependency touched: no
- CI status: not re-verified (PR from 2023; previously reviewed with a comment only, no approval)
Verdict
Comment — please split this into separate PRs (search feature vs. code-block styling vs. the nav-toggle div removal) and confirm the DOM structure change is intentional and tested. Not blocking as no clear security/data-loss issue is visible, but scope and risk should be narrowed before merge.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
|
Closing this PR. Thanks for the original contribution! On review, the one part that directly addresses #439 is the Rather than untangle and rebase all of that, I've pulled the focused code-block styling into a fresh single-purpose PR: #560. That keeps the useful fix and drops the unrelated scope. Closing as superseded by #560. |
6 participants
No description provided.