fix: Improve target option processing in js.js#41729
Open
odaysec wants to merge 1 commit into
Open
Conversation
Refactor target option handling to avoid HTML parsing. fix is to avoid passing potentially untrusted values directly to `$()` in the fallback branch. Keep selector strings handled via `$(document).find(...)`, and for non-string values only pass through safe object types (DOM node, window/document, jQuery object, event target). If an unexpected value is provided, resolve to an empty jQuery set instead of invoking `$()` on it. In `core/js/js.js`, update the `target` initialization around lines 2669–2672. Replace the current ternary with a small IIFE that: - uses `$( document ).find( options.of )` for string selectors, - uses `options.of.target` for event objects (if present), - accepts jQuery objects and DOM-like objects directly, - otherwise returns `$()`.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor target option handling to avoid HTML parsing. fix is to avoid passing potentially untrusted values directly to
$()in the fallback branch. Keep selector strings handled via$(document).find(...), and for non-string values only pass through safe object types (DOM node, window/document, jQuery object, event target). If an unexpected value is provided, resolve to an empty jQuery set instead of invoking$()on it.In
core/js/js.js, update thetargetinitialization around lines 2669–2672. Replace the current ternary with a small IIFE that:$( document ).find( options.of )for string selectors,options.of.targetfor event objects (if present),$().Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: