-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] [tests-only]WebUI tests added to share resource with multiple users at once #40546
Merged
phil-davis
merged 5 commits into
master
from
add-webui-test-sharing-with-multiple-users-at-once
Jan 3, 2023
Merged
[full-ci] [tests-only]WebUI tests added to share resource with multiple users at once #40546
phil-davis
merged 5 commits into
master
from
add-webui-test-sharing-with-multiple-users-at-once
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grgprarup
requested review from
kiranparajuli589,
SwikritiT,
SagarGi,
saw-jan and
amrita-shrestha
December 21, 2022 02:39
tests/acceptance/features/webUISharingInternalUsers1/createShareWithUsers.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalUsers1/createShareWithUsers.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalUsers1/createShareWithUsers.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalUsers1/createShareWithUsers.feature
Outdated
Show resolved
Hide resolved
grgprarup
force-pushed
the
add-webui-test-sharing-with-multiple-users-at-once
branch
2 times, most recently
from
December 21, 2022 06:13
53ffd49
to
3d706e7
Compare
saw-jan
reviewed
Dec 21, 2022
saw-jan
reviewed
Dec 21, 2022
saw-jan
reviewed
Dec 21, 2022
tests/acceptance/features/lib/FilesPageElement/SharingDialog.php
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Dec 21, 2022
tests/acceptance/features/lib/FilesPageElement/SharingDialog.php
Outdated
Show resolved
Hide resolved
grgprarup
force-pushed
the
add-webui-test-sharing-with-multiple-users-at-once
branch
from
December 21, 2022 09:31
33b93cc
to
a69511d
Compare
grgprarup
force-pushed
the
add-webui-test-sharing-with-multiple-users-at-once
branch
from
December 22, 2022 03:23
a69511d
to
3ef59f3
Compare
saw-jan
reviewed
Dec 22, 2022
tests/acceptance/features/webUISharingInternalUsers1/createShareWithUsers.feature
Show resolved
Hide resolved
SagarGi
reviewed
Dec 22, 2022
SagarGi
reviewed
Dec 22, 2022
tests/acceptance/features/webUISharingInternalUsers1/createShareWithUsers.feature
Show resolved
Hide resolved
saw-jan
reviewed
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
grgprarup
force-pushed
the
add-webui-test-sharing-with-multiple-users-at-once
branch
from
December 27, 2022 03:00
750ba20
to
3495e89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
grgprarup
force-pushed
the
add-webui-test-sharing-with-multiple-users-at-once
branch
from
January 2, 2023 07:31
3495e89
to
fb6eae0
Compare
saw-jan
reviewed
Jan 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
grgprarup
force-pushed
the
add-webui-test-sharing-with-multiple-users-at-once
branch
from
January 2, 2023 08:46
fb6eae0
to
77fc1bf
Compare
individual-it
approved these changes
Jan 2, 2023
phil-davis
approved these changes
Jan 3, 2023
delete-merged-branch
bot
deleted the
add-webui-test-sharing-with-multiple-users-at-once
branch
January 3, 2023 03:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds WebUI tests for sharing resources with multiple users at once. Since the CI is green every time but when testing locally we might face the issue mentioned here #40548
Scenarios included:
Scenario: user shares file with multiple users at once
Scenario: user shares folder with multiple users at once
Scenario Outline: user shares file with multiple users including non-existing user at once
Scenario: user shares folder with multiple users including non-existing user at once
Scenario: user shares file with multiple users having exact same group name
Scenario: user shares folder with multiple users having exact same group name
Related Issue
How Has This Been Tested?
Types of changes
Checklist: