Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only]WebUI tests added to share resource with multiple users at once #40546

Merged

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Dec 20, 2022

Description

This PR adds WebUI tests for sharing resources with multiple users at once. Since the CI is green every time but when testing locally we might face the issue mentioned here #40548
Scenarios included:

  • Scenario: user shares file with multiple users at once
  • Scenario: user shares folder with multiple users at once
  • Scenario Outline: user shares file with multiple users including non-existing user at once
  • Scenario: user shares folder with multiple users including non-existing user at once
  • Scenario: user shares file with multiple users having exact same group name
  • Scenario: user shares folder with multiple users having exact same group name

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup force-pushed the add-webui-test-sharing-with-multiple-users-at-once branch 2 times, most recently from 53ffd49 to 3d706e7 Compare December 21, 2022 06:13
@grgprarup grgprarup force-pushed the add-webui-test-sharing-with-multiple-users-at-once branch from 33b93cc to a69511d Compare December 21, 2022 09:31
@grgprarup grgprarup force-pushed the add-webui-test-sharing-with-multiple-users-at-once branch from a69511d to 3ef59f3 Compare December 22, 2022 03:23
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grgprarup grgprarup force-pushed the add-webui-test-sharing-with-multiple-users-at-once branch from 750ba20 to 3495e89 Compare December 27, 2022 03:00
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@grgprarup grgprarup force-pushed the add-webui-test-sharing-with-multiple-users-at-once branch from 3495e89 to fb6eae0 Compare January 2, 2023 07:31
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@grgprarup grgprarup force-pushed the add-webui-test-sharing-with-multiple-users-at-once branch from fb6eae0 to 77fc1bf Compare January 2, 2023 08:46
@phil-davis phil-davis merged commit 2adfe15 into master Jan 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-webui-test-sharing-with-multiple-users-at-once branch January 3, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants