[DC-231] improvements for tree navigation and edit states#12468
Merged
[DC-231] improvements for tree navigation and edit states#12468
Conversation
redundant: small cleanup
added an event filter to allow setting the current item to edit mode when tree view gets focus. also updated the paints for the folder item delegate to better deal with the tree's indent. updated some comments too
added a "multiload" switch to prevent onFolderAdded from sorting the model on every call. also refined the behavior on current item change
redundant: as it says in the description
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
…into refactor/dc-231
…into refactor/dc-231
also made sure all "actionable" widgets have strong focus
as described
…into refactor/dc-231
copy pasta ick, the return type on messagebox exec did not match the handling conditions
as the title says
as described
small bug fix that make sure current selected item in tree is scrolled to when focus in (via keyboard, obvs)
the folder wizard was fine when run from the "add folder" button but completely busted when run via the account wizard/selective sync option. this is why duplicated code is BAD. I will refactor more heavily to end up with a single impl for this, but for now, need to get squish updated so this simpler fix is ok.
that.
DeepDiver1975
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-231