This repository has been archived by the owner on Nov 14, 2018. It is now read-only.
Add new site target option to External Site options #2221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2017
This was referenced Sep 9, 2017
|
@Peter-Prochaska can you review this ? |
peterprochaska
suggested changes
Sep 12, 2017
| strip_tags($_POST['site_url'][$i]), | ||
| strip_tags($_POST['site_icon'][$i]), | ||
| strip_tags($_POST['site_target'][$i]), | ||
| )); |
There was a problem hiding this comment.
I think strip_tags is not enough here. Because you always can inject " onLoad="javascript:alert('XSS')" <- which tags should strip_tags remove?
Use htmlspecialchars or similar for escaping.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
site_targetoption which lets users specify whether an External Site is framed by owncloud, replaces the current window, or opens in a separate window.Picking up stale PR: #2216
Fixes:
Adds:
Questions:
How can I import the value
$targetsdefined inexternal/settings.phpintoexternal/ajax/setsites.php?Is there some helper function like
getAppConfig().getKey('targets')orgetAppSettings('external')['targets']?