-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ log explorer views to google analytics #4098
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite |
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-10-31 15:48:38 UTC |
df5dcae
to
526fa8e
Compare
dd55a5e
to
92bd6c7
Compare
526fa8e
to
c3ee9a3
Compare
92bd6c7
to
7fcadf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work!
Thank you for the review! |
7fcadf9
to
bb8c634
Compare
Resolves #4094
Summary
A view event is logged to Google Analytics when an Explorer is rendered and when the view is changed.
Details
Logged events are of the following shape:
Testing
I tested this code by console logging when an event is fired, but I haven't checked to see if these events actually end up in GA.