🐛 (stacked discrete bar) wrap long labels #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
sophiamersmann
force-pushed
the
stacked-discrete-bar-wrap-labels
branch
2 times, most recently
from
2e18aa1
to
8071ecc
Compare
sophiamersmann
changed the title
sophiamersmann
changed the title
sophiamersmann
force-pushed
the
stacked-discrete-bar-wrap-labels
branch
from
8071ecc
to
00e7dad
Compare
sophiamersmann
commented
Mar 14, 2024
Comment on lines
+393
to
+397
| // useful if `this.barHeight` can't be used due to a cyclic dependency | ||
| // keep in mind though that this is not exactly the same as `this.barHeight` | ||
| @computed private get approximateBarHeight(): number { | ||
| return (0.8 * this.boundsWithoutLegend.height) / this.barCount | ||
| } |
There was a problem hiding this comment.
There is a circular dependency here that I can't get rid of easily. If I remember correctly, it's something like: labelFontSize -> barHeight -> innerBounds -> labelWidth -> labelStyle -> labelFontSize.
Breaking the cycle by using boundsWithoutLegend instead of innerBounds is not new, but I added a computed property that makes it explicit.
marcelgerber
approved these changes
Mar 14, 2024
sophiamersmann
force-pushed
the
stacked-discrete-bar-wrap-labels
branch
from
00e7dad
to
128013c
Compare
|
Maybe write an issue for it? It could be a cool cooldown project :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2629
We should also do this for DiscreteBar charts, but I don't have time now. I added a note to the issue above 👆🏻