Add async error handling to FunctionalRouter

owid · May 14, 2024 · 9b4d68a · 9b4d68a
1 parent 5a56145
commit 9b4d68a
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/adminSiteServer/FunctionalRouter.ts b/adminSiteServer/FunctionalRouter.ts
@@ -1,4 +1,4 @@
-import express, { Router } from "express"
+import express, { NextFunction, Router } from "express"
 import { Request, Response } from "./authentication.js"
 
 // Little wrapper to automatically send returned objects as JSON, makes
@@ -13,13 +13,12 @@ export class FunctionalRouter {
     }
 
     wrap(callback: (req: Request, res: Response) => Promise<any>) {
-        return async (req: Request, res: Response) => {
+        return async (req: Request, res: Response, next: NextFunction) => {
             try {
                 res.send(await callback(req, res))
             } catch (e) {
-                // log errors to stderr and rethrow
                 console.error(e)
-                throw e
+                next(e)
             }
         }
     }