Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Cache indicator data from S3 #3398

Merged
merged 2 commits into from
Oct 11, 2024
Merged

🔨 Cache indicator data from S3 #3398

merged 2 commits into from
Oct 11, 2024

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Oct 11, 2024

Cache indicator data from S3 to disk along with its ETag. When fetching it again, first compare its checksum to the cached version, and if they match, load it from disk instead. This should improve data loading speed in Anomalist.

@Marigold Marigold marked this pull request as ready for review October 11, 2024 09:01
@owidbot
Copy link
Contributor

owidbot commented Oct 11, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-cache-s3-data

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-10-11 09:03:07 UTC
Execution time: 15.16 seconds

Copy link
Member

@lucasrodes lucasrodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for implementing this!

@Marigold Marigold merged commit be3b40c into master Oct 11, 2024
8 checks passed
@Marigold Marigold deleted the cache-s3-data branch October 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants