-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use real users on staging servers #3341
Conversation
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundLegend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2024-10-30 06:16:12 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is very useful! The code looks good. I'm not sure how I can test it. Please let me know if you want me to test it on my current branch or elsewhere.
Goes together with owid/owid-grapher#4083 that automatically logs Tailscale users to Admin. This means that going to http://staging-site-feature won't ask you to login as
admin
user and won't show an annoying popup about compromised password.On ETL side, charts are created by logged user instead of ETL and synced correctly to production by chart-diff.
Datasets will still be created by ETL user, because they're created in production and there's no easy way how to know who created it. That is, unless we add
owner
to dataset metadata and start using it.TODO before merging