Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ wizard: option to show archived datasets #3335

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Sep 30, 2024

Pablo Arriagada reported that he could not view archived datasets in Indicator Upgrader (as part of his work in #3343).

To overcome this, he unarchived a dataset.

This PR solves this by allowing the user to show archived datasets if they click the 'show all datasets' option.

image

@owidbot
Copy link
Contributor

owidbot commented Sep 30, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-show-archived-datasets

chart-diff: ✅
  • 1/1 reviewed charts
    • Modified: 1/1
    • New: 0/0
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-10-01 11:05:32 UTC
Execution time: 3.65 seconds

Copy link
Contributor

@paarriagadap paarriagadap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me! Thanks!

I also found another chart with the exact same issue:
https://admin.owid.io/admin/variables/819727

@paarriagadap paarriagadap marked this pull request as ready for review September 30, 2024 17:28
@lucasrodes lucasrodes merged commit c6933b3 into master Oct 1, 2024
12 checks passed
@lucasrodes lucasrodes deleted the show-archived-datasets branch October 1, 2024 11:32
paarriagadap pushed a commit that referenced this pull request Oct 6, 2024
* ✨ wizard: option to show archived datasets

* show archived datasets

* show latest datasets first in dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants