Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 mpox: Using xmart API endpoint #3282

Merged
merged 1 commit into from
Sep 16, 2024
Merged

🔧 mpox: Using xmart API endpoint #3282

merged 1 commit into from
Sep 16, 2024

Conversation

spoonerf
Copy link
Contributor

No description provided.

@spoonerf spoonerf marked this pull request as ready for review September 13, 2024 07:59
@owidbot
Copy link
Contributor

owidbot commented Sep 13, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-mpox-new-api

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-09-13 08:00:39 UTC
Execution time: 13.28 seconds

Copy link
Collaborator

@Marigold Marigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoint works. Unfortunately the latest data is from 2024-09-04, so there's no new data compared to the existing snapshot.

@spoonerf
Copy link
Contributor Author

@Marigold Shall we merge for now and then continue looking for where the newer data can be sourced?

@Marigold
Copy link
Collaborator

Shall we merge for now and then continue looking for where the newer data can be sourced?

Up to you. I fear that using xmart endpoint might be hiding the real problem. I'd wait till Monday to see if running python snapshots/who/latest/monkeypox.py updates any data.

@spoonerf
Copy link
Contributor Author

@Marigold Okay sounds good, let's hold fire. Is it currently preventing the second snapshot in the automated script running?

@lucasrodes lucasrodes changed the title 🔧 Using xmart API endpoint for mpox 🔧 mpox: Using xmart API endpoint Sep 14, 2024
@Marigold
Copy link
Collaborator

@Marigold Okay sounds good, let's hold fire. Is it currently preventing the second snapshot in the automated script running?

Oh, you're right, it fails and never executes the second one. Then I think we should merge this one, even if it doesn't add any data (I just checked).

@spoonerf spoonerf merged commit 7a821d4 into master Sep 16, 2024
16 checks passed
@spoonerf spoonerf deleted the mpox-new-api branch September 16, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants