Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 gbd-risk: Add missing percentages #3262

Merged
merged 4 commits into from
Sep 10, 2024
Merged

🐛 gbd-risk: Add missing percentages #3262

merged 4 commits into from
Sep 10, 2024

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Sep 10, 2024

Percentages from gbd_risk dataset such as this one got removed by this commit. Because of that, ETL tries to rebuild gbd_risk every time it runs and then throws a warning.

This PR adds run_percent=True argument to regional aggregates to put them back. It also raises an error on staging servers when there are variables that cannot be deleted automatically.

@Marigold Marigold marked this pull request as ready for review September 10, 2024 08:58
@owidbot
Copy link
Contributor

owidbot commented Sep 10, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fix-gbd-risk

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-09-10 09:04:27 UTC
Execution time: 12.92 seconds

Copy link
Contributor

@spoonerf spoonerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for finding this! So we don't want regional aggregates for percentages for gbd_risk as there's some weird stuff going on their (some 'risks' reduce your chance of dying), so run_percent has to stay False.

But I think there was a broader issue in shared.py, meaning that all aggregate percentages were getting dropped unless run_percent = True, which isn't what we wanted.

Have changed it now, I think that also fixes the original issue?

@lucasrodes lucasrodes changed the title 🐛 Add missing percentages for gbd-risk 🐛 gbd-risk: Add missing percentages Sep 10, 2024
@Marigold
Copy link
Collaborator Author

Have changed it now, I think that also fixes the original issue?

Yep, much better!

@Marigold Marigold merged commit bcf0c24 into master Sep 10, 2024
9 checks passed
@Marigold Marigold deleted the fix-gbd-risk branch September 10, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants