Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Refactor fast track & add origins #1377

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Jul 25, 2023

This PR was originally only refactoring, but I ended up adding origins as well. Let me know if this is too hard to review and I can split it in two.

Refactoring Fast-track

Simplify fast-track. Allow only one source / origin and get rid of source's short_name (which has caused just confusion in the past). No one has used multiple sources so far. Having just one source simplified the logic a lot. It's all backward compatible.

Add origins

Add new sheet origins_meta. Here's an example of the new template (note that I'll have to update template after merging this to avoid breaking old fast-track spreadsheets). It's very bare-bones at the moment. I'll polish it when we start using it.

TODO

  • test loading from CSV
  • test loading from S3 path
  • add origins
  • make sure as much metadata as possible is saved in Origin YAML
  • modify fasttrack template to allow only one source / origin

Edits to template spreadsheet

  • remove all sources fields
  • add origins sheet
  • add CHANGELOG sheet with updates

@Marigold Marigold marked this pull request as draft July 25, 2023 10:38
@Marigold Marigold force-pushed the refactor-fast-track branch 4 times, most recently from 94653ce to 75bf636 Compare August 14, 2023 13:39
@Marigold Marigold marked this pull request as ready for review August 14, 2023 13:39
@Marigold Marigold changed the title 🔨 Refactor fast track 🔨 Refactor fast track & add origins Aug 14, 2023
@pabloarosado
Copy link
Contributor

Quick note: I just swapped the values of producer and citation_producer in the template.

Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it, but it looks fine.

@Marigold Marigold merged commit 445d4eb into master Aug 17, 2023
3 checks passed
@Marigold Marigold deleted the refactor-fast-track branch August 17, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants