-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Add origins as a default to walkthrough #1369
Conversation
f073bb9
to
d37d0a5
Compare
d37d0a5
to
21e5421
Compare
21e5421
to
d55dc5a
Compare
@Marigold I rebased this branch and force pushed it after some changes and brought this branch in line with the last field renames |
4834b7f
to
b7b2575
Compare
cec3079
to
c3f4d12
Compare
c3f4d12
to
e120d45
Compare
Hi @Marigold I'm going through a small dataset, and the snapshot step went well! Now, when running the meadow step, I unticked the box to create a playground notebook, and got:
The meadow step was successfully created though, but I guess the above error is a bug (I haven't looked into it, just informing you). |
It was a bug, fixed. Thanks for spotting it. |
d8e0677
to
bb01bbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I will make some small changes in a future PR, but for now let's merge to avoid blocking other things, thanks!
da95151
to
f0d9704
Compare
walkthrough snapshot
instead of sourceI tested all steps on a dummy dataset by running
walkthrough snapshot --dummy-data
This should ideally be merged only after merging
origins
branch to master and rebasing.