Repository navigation
fix: update the Dockerfile - #149
Merged
Merged
Conversation
The mismatch between `FROM` and `as` triggered a warning on every build.
* Add error handling (`-S`, `test`).
* Update the regex to be more specific.
- Hugo has 2 variants that match `hugo_extended`: `hugo_extended` and
`hugo_extended_withdeploy`. Update the regex to exclude the
unwanted one.
- Escape the dots and add anchors.
* Don't use the version variable to name the assets.
This is a temporary container, so there's no need for the version in
the filename.
* Add error handling. * Update the regex to be more specific. * Don't use the version variable to name the assets. This is a temporary container, so there's no need for the version in the filename. * Move the entire `dart-sass` folder. `sass` is just a shell script that invokes the actual binary. The binary needs to be copied as well.
Contributor
Author
|
Tested locally, working properly. |
Contributor
Author
|
The next step would be to add a CI job that built the container and checked that it's serving content. This would add a regression test to ensure that the Dockerfile works. |
Member
|
Thanks for this addition, @aryehb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AS.The mismatch between
FROMandastriggered a warning on every build.CMD.servealias to match the non-Docker instructions in the README.0.0.0.0so the port can be forwarded to the host.-S,test).hugo_extended:hugo_extendedandhugo_extended_withdeploy. Update the regex to exclude the unwanted one.This is a temporary container, so there's no need for the version in the filename.
This is a temporary container, so there's no need for the version in the filename.
dart-sassfolder.sassis just a shell script that invokes the actual binary. The binary needs to be copied as well.