Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARC-1700: Spicegen: Add permission factory methods #4

Merged
merged 7 commits into from
May 24, 2024

Conversation

thomasrichner-oviva
Copy link
Contributor

@thomasrichner-oviva thomasrichner-oviva commented May 23, 2024

  • also generate code for permission checks
  • add generic permission check implementation

Copy link
Collaborator

@shivantaher-oviva shivantaher-oviva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, left some initial thoughts. Still need to dig a bit deeper into the integration test.

api/src/main/java/com/oviva/spicegen/api/Consistency.java Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
Copy link
Collaborator

@shivantaher-oviva shivantaher-oviva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@thomasrichner-oviva thomasrichner-oviva merged commit 2337d7d into main May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants