Skip to content

Conversation

@SaqAsh
Copy link
Contributor

@SaqAsh SaqAsh commented Jun 4, 2025

Summary

Issues

Description of Changes

  • Add ExpandAllButton and CollapseAllButton components for toggling all items open/closed.
  • Add underlying Button component, slightly refactored from the Button component from the stage repository
  • Add necessary icons to match Figma requirements in addition to the Loading icon to successfully port over the Button component from stage
  • Add corresponding Storybook stories

Readiness Checklist

  • Self Review
    • I have performed a self review of code
    • I have run the application locally and manually tested the feature
    • I have checked all updates to correct typos and misspellings
  • Formatting
    • Code follows the project style guide
    • Autmated code formatters (ie. Prettier) have been run
  • Local Testing
    • Successfully built all packages locally
    • Successfully ran all test suites, all unit and integration tests pass
  • Updated Tests
    • Unit and integration tests have been added that describe the bug that was fixed or the features that were added
  • Documentation
    • All new environment variables added to .env.schema file and documented in the README
    • All changes to server HTTP endpoints have open-api documentation
    • All new functions exported from their module have TSDoc comment documentation

@SaqAsh SaqAsh linked an issue Jun 10, 2025 that may be closed by this pull request
1 task
@SaqAsh SaqAsh requested a review from joneubank June 10, 2025 18:47
Copy link
Contributor

@ciaranschutte ciaranschutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some cleanup to do in parts, looking good

// Animation
const spin = keyframes`
100% {
transform: rotate(360deg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is prettier formatting enabled? transform should be indented in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier is enabled, not sure why it didn't indent it

@SaqAsh SaqAsh requested a review from ciaranschutte June 24, 2025 12:39
ciaranschutte
ciaranschutte previously approved these changes Jun 24, 2025
@ciaranschutte ciaranschutte self-requested a review June 24, 2025 17:21
@ciaranschutte ciaranschutte dismissed joneubank’s stale review June 25, 2025 11:01

Dismissing, all suggested changes have been implemented

@SaqAsh SaqAsh merged commit 17550fa into main Jun 25, 2025
2 checks passed
@SaqAsh SaqAsh deleted the feature/expand-collapse-all-button branch June 25, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2B. Expand All / Collapse All

5 participants