-
Notifications
You must be signed in to change notification settings - Fork 4
#271: Implement Expand All and Collapse All Buttons #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/ui/src/viewer-table/InteractionPanel/CollapseAllButton.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/viewer-table/InteractionPanel/ExpandAllButton.tsx
Outdated
Show resolved
Hide resolved
packages/ui/stories/viewer-table/interaction-panel/CollapseAllButton.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/viewer-table/InteractionPanel/CollapseAllButton.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/viewer-table/InteractionPanel/CollapseAllButton.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/viewer-table/InteractionPanel/ExpandAllButton.tsx
Outdated
Show resolved
Hide resolved
ciaranschutte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some cleanup to do in parts, looking good
| // Animation | ||
| const spin = keyframes` | ||
| 100% { | ||
| transform: rotate(360deg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is prettier formatting enabled? transform should be indented in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier is enabled, not sure why it didn't indent it
packages/ui/src/viewer-table/InteractionPanel/CollapseAllButton.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/viewer-table/InteractionPanel/ExpandAllButton.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/viewer-table/InteractionPanel/ExpandAllButton.tsx
Outdated
Show resolved
Hide resolved
Dismissing, all suggested changes have been implemented
Summary
Issues
Description of Changes
ExpandAllButtonandCollapseAllButtoncomponents for toggling all items open/closed.Buttoncomponent, slightly refactored from theButtoncomponent from thestagerepositoryLoadingicon to successfully port over theButtoncomponent from stageReadiness Checklist
.env.schemafile and documented in the README