Skip to content

Commit

Permalink
Merge pull request #56 from edmondscommerce/DeprecatedErrorFix
Browse files Browse the repository at this point in the history
fixing Symfony console error: Passing a command as string when creati…
  • Loading branch information
overtrue authored Jan 3, 2019
2 parents 46d8846 + 77c4d48 commit 6fd4d10
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Linter.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function lint($files = [], $cache = true)
$filename = $file->getRealPath();
$relativePathname = $file->getRelativePathname();
if (!isset($this->cache[$relativePathname]) || $this->cache[$relativePathname] !== md5_file($filename)) {
$lint = new Lint(escapeshellcmd($phpbin).' -d error_reporting=E_ALL -d display_errors=On -l '.escapeshellarg($filename));
$lint = Lint::fromShellCommandline(escapeshellcmd($phpbin).' -d error_reporting=E_ALL -d display_errors=On -l '.escapeshellarg($filename));
$running[$filename] = [
'process' => $lint,
'file' => $file,
Expand Down

3 comments on commit 6fd4d10

@edmondscommerce
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick turnaround 👍

@tuupola
Copy link
Contributor

@tuupola tuupola commented on 6fd4d10 Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke my PHP 5.6 and 7.0 builds. It seems that Process::fromShellCommandline() was introduced in symfony/process:4.2.0 which requires ^7.1.3. The new minimal requirements should also be added to composer.json.

@overtrue
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuupola plz upgrade to 1.1.9 dab0415

Please sign in to comment.