Fixed #166

overtrue · Apr 6, 2022 · 7e126f7 · 7e126f7
1 parent 1a539df
commit 7e126f7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/src/Followable.php b/src/Followable.php
@@ -34,9 +34,9 @@ public function follow($user): array
         /** @var \Illuminate\Database\Eloquent\Model|\Overtrue\LaravelFollow\Followable $user */
         $isPending = $user->needsToApproveFollowRequests() ?: false;
 
-        $this->followings()->attach($user, [
+        $this->followings()->syncWithPivotValues($user, [
             'accepted_at' => $isPending ? null : now()
-        ]);
+        ], false);
 
         return ['pending' => $isPending];
     }

diff --git a/tests/FeatureTest.php b/tests/FeatureTest.php
@@ -3,6 +3,7 @@
 namespace Tests;
 
 use Illuminate\Support\Carbon;
+use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\Event;
 use Overtrue\LaravelFollow\Events\Followed;
 use Overtrue\LaravelFollow\Events\Unfollowed;
@@ -290,4 +291,24 @@ public function test_order_by_followers()
         $this->assertSame($user1->name, $mostPopularUser->name);
         $this->assertEquals(3, $mostPopularUser->followers_count);
     }
+
+    public function test_repeat_actions()
+    {
+        $user1 = User::create(['name' => 'user1']);
+        $user2 = User::create(['name' => 'user2']);
+        $user3 = User::create(['name' => 'user2']);
+        $user4 = User::create(['name' => 'user2']);
+
+        $user1->follow($user2);
+        $user1->follow($user2);
+        $user1->follow($user2);
+        $user1->follow($user3);
+        $user1->follow($user4);
+
+        $this->assertDatabaseHas('user_follower', ['follower_id' => $user1->id, 'following_id' => $user2->id]);
+        $this->assertDatabaseHas('user_follower', ['follower_id' => $user1->id, 'following_id' => $user3->id]);
+        $this->assertDatabaseHas('user_follower', ['follower_id' => $user1->id, 'following_id' => $user4->id]);
+
+        $this->assertDatabaseCount('user_follower', 3);
+    }
 }