feat: getting rid of dockerize #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2024
|
My biggest worry is to discover that we actually need dockerize to wait for mongodb/elasticsearch to start, for instance in init jobs. Did you check this? |
regisb
reviewed
Jul 23, 2024
tutorforum/templates/forum/build/forum/bin/docker-entrypoint.sh
Outdated
Show resolved
Hide resolved
ghassanmas
force-pushed
the
remove-dockerize
branch
2 times, most recently
from
391ec34 to
be4423a
Compare
ghassanmas
force-pushed
the
remove-dockerize
branch
from
be4423a to
47ca02d
Compare
|
@ghassanmas Hi, what's the plan for this PR? Thanks |
ghassanmas
force-pushed
the
remove-dockerize
branch
from
47ca02d to
7d09fbd
Compare
|
@regisb @DawoudSheraz |
ghassanmas
force-pushed
the
remove-dockerize
branch
from
7d09fbd to
905565a
Compare
changelog.d/20240722_163119_ghassan.maslamani_remove_dockerize.md
Outdated
Show resolved
Hide resolved
changelog.d/20240722_163119_ghassan.maslamani_remove_dockerize.md
Outdated
Show resolved
Hide resolved
DawoudSheraz
approved these changes
Oct 14, 2024
getting rid of dockerize might resolve #33 and provide other solution for #35 dockerize is used for waiting for other services, in order replicate it's effect, we set `MONGOID_TIMEOUT` 600 second for mongodb, related upstream PR: - openedx/cs_comments_service/pull/432
ghassanmas
force-pushed
the
remove-dockerize
branch
from
905565a to
2385b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting rid of dockerize might resolve #39 and provide other
solution for #35
dockerize is used for waiting for other services, in order
replicate it's effect, we set
MONGOID_TIMEOUT600 secondfor mongodb, related upstream PR:
connect_timoutmongoid openedx/cs_comments_service#432Todo:
connect_timoutmongoid openedx/cs_comments_service#432 (comment)