fix: app version #47
Open
fix: app version #47
+37
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only using `OPENEDX_COMMON_VERSION` and there was no room to use a custom branch/version. Close overhangio#46
We need to make it simpler for devs to debug this plugin without any previous setup.
with this, we can set the APPLICATION_ID inside `tutor.yml`
This ensure dynamic handling of APP_VERSION in Dockerfile without passing an argument in build level
CodeWithEmad
force-pushed
the
fix/app-version
branch
from
22c9f63 to
b9cc3ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we can pass arguments to dockerfile, but why not using the tutor configs?
This fixes the app version issue, introduces
ANDROID_APP_IDto set theAPPLICATION_IDinsidetutor.yml, and enhances the readme for better readability and syntax highlighting.Close #46