-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sql) disable idle timeout when still processing data #16984
base: main
Are you sure you want to change the base?
Conversation
Updated 2:51 AM PT - Feb 2nd, 2025
❌ @cirospaciari, your commit 8ab60c0 has 3 failures in
🧪 try this PR locally: bunx bun-pr 16984 |
195fa6a
to
b7b072a
Compare
maybe instead it'd be better to reset the connection timeout at both the start and end of the onData callback? |
I just disable the idle timeout when processing the data, if we are processing data we are active/busy not idle. |
…h is better for this test
…pdate ref here since we will unref/ref when onData ends
What does this PR do?
Fix: #16892
Disable idle timeout when processing data, fix short read handling, remove unnecessary/dead code and small refactor
How did you verify your code works?
Test