Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql) disable idle timeout when still processing data #16984

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Feb 2, 2025

What does this PR do?

Fix: #16892

Disable idle timeout when processing data, fix short read handling, remove unnecessary/dead code and small refactor

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Test

@robobun
Copy link

robobun commented Feb 2, 2025

Updated 2:51 AM PT - Feb 2nd, 2025

@cirospaciari, your commit 8ab60c0 has 3 failures in Build #11014:


🧪   try this PR locally:

bunx bun-pr 16984

@Jarred-Sumner
Copy link
Collaborator

maybe instead it'd be better to reset the connection timeout at both the start and end of the onData callback?

@cirospaciari cirospaciari marked this pull request as draft February 2, 2025 06:21
@cirospaciari cirospaciari changed the title fix(sql) reset idle timeout when receiving partial data set fix(sql) disable idle timeout when still processing data Feb 2, 2025
@cirospaciari cirospaciari marked this pull request as ready for review February 2, 2025 06:28
@cirospaciari
Copy link
Member Author

cirospaciari commented Feb 2, 2025

maybe instead it'd be better to reset the connection timeout at both the start and end of the onData callback?

I just disable the idle timeout when processing the data, if we are processing data we are active/busy not idle.

@cirospaciari cirospaciari marked this pull request as draft February 2, 2025 08:27
@cirospaciari cirospaciari marked this pull request as ready for review February 2, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL from bun gets timeouts very easly
3 participants