Clean up error throwing code in UDP sockets #16959
Open
+25
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
JSC.Maybe(void).errnoSys
can return null if errno is 0. This leads to a null pointer dereference, most likely causing the below crash:Bun v1.2.1 (ce53290) on linux x86_64 [AutoCommand]
Segmentation fault at address 0x00000000
uws.zig:4563: src.bun.js.api.bun.udp_socket.UDPSocket.setMembership
udp_socket.zig:469: UDPSocketPrototype__addMembership
ZigGeneratedClasses.cpp:47883: WebCore::UDPSocketPrototype__addMembershipCallback
1 unknown/js code
ld-temp.o:0: llint_op_call_ignore_result
ld-temp.o:0: llint_op_call_ignore_result
ld-temp.o:0: llint_op_call_ignore_result
ld-temp.o:0: llint_op_call_ignore_result
How did you verify your code works?