Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when calling close() on a dgram socket multiple times #16928

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heimskr
Copy link
Member

@heimskr heimskr commented Jan 31, 2025

What does this PR do?

Prevents a property lookup on null when closing the same dgram socket multiple times.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tried closing a socket multiple times.

@robobun
Copy link

robobun commented Jan 31, 2025

Updated 5:58 PM PT - Jan 30th, 2025

@heimskr, your commit cbdbcbe has 2 failures in Build #10887:


🧪   try this PR locally:

bunx bun-pr 16928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants