sqlite: enable SQLITE_ENABLE_UPDATE_DELETE_LIMIT compilation option #16884
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbenincasa
force-pushed
the
sqlite-opts
branch
from
86ba2d8 to
35c08cd
Compare
5 tasks
chrisbenincasa
added a commit
to chrisbenincasa/tunarr
that referenced
this pull request
Jan 30, 2025
This is necessary until Bun enables the feature in sqlite: oven-sh/bun#16909 and oven-sh/bun#16884
chrisbenincasa
added a commit
to chrisbenincasa/tunarr
that referenced
this pull request
Jan 30, 2025
This is necessary until Bun enables the feature in sqlite: oven-sh/bun#16909 and oven-sh/bun#16884
chrisbenincasa
added a commit
to chrisbenincasa/tunarr
that referenced
this pull request
Jan 30, 2025
This is necessary until Bun enables the feature in sqlite: oven-sh/bun#16909 and oven-sh/bun#16884
chrisbenincasa
added a commit
to chrisbenincasa/tunarr
that referenced
this pull request
Jan 30, 2025
This is necessary until Bun enables the feature in sqlite: oven-sh/bun#16909 and oven-sh/bun#16884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables the SQLITE_ENABLE_UPDATE_DELETE_LIMIT compilation flag for sqlite, which allows for specifying a LIMIT on UPDATE and DELETE queries
How did you verify your code works?
Simply enables a compilation flag in sqlite that has been around since 3.6.20, which enables a pretty standard and expected SQL feature (unsure why SQLite hasn't made this the default...
Will happily test with my project https://github.com/chrisbenincasa/tunarr as I've just integrated Bun (and am very happy with it so far!) but this is a blocker for me to cut a full release with as it breaks many queries in the app.
I was previous using better-sqlite3 with success; it enables this option and many others (may have to add those here too!)