+5 passing node:zlib tests #15944
Merged
+5 passing node:zlib tests #15944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 10:12 AM PT - Dec 22nd, 2024
✅ @Jarred-Sumner, your commit b77d569 has passed in 🧪 try this PR locally: bunx bun-pr 15944 |
nektro
approved these changes
Dec 23, 2024
| if (!common.isMainThread) { | ||
| common.skip('Cannot test the existence of --expose-internals from worker'); | ||
| } | ||
| common.skip("This test is not going to be implemented in Bun. We do not support --expose-internals.") |
There was a problem hiding this comment.
common.skip exits the process so the commenting out below here is unnecessary btw
| @@ -662,16 +671,14 @@ pub const NativeBrotli = JSC.Codegen.JSNativeBrotli.getConstructor; | |||
|
|
|||
| pub const SNativeBrotli = struct { | |||
| pub usingnamespace bun.NewRefCounted(@This(), deinit); | |||
| pub usingnamespace JSC.Codegen.JSNativeZlib; | |||
| pub usingnamespace JSC.Codegen.JSNativeBrotli; | |||
Comment on lines
+774
to
+777
| switch (this.stream.mode) { | ||
| .BROTLI_ENCODE, .BROTLI_DECODE => this.stream.close(), | ||
| else => {}, | ||
| } |
There was a problem hiding this comment.
Suggested change
| switch (this.stream.mode) { | |
| .BROTLI_ENCODE, .BROTLI_DECODE => this.stream.close(), | |
| else => {}, | |
| } | |
| this.stream.close(); |
There was a problem hiding this comment.
There's an assertion in there related to .mode so I was doing this to be cautious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
+5 passing node:zlib tests
thisvalue when it wasn't necessaryHow did you verify your code works?
Ran existing node tests and verified they pass