Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vscode debugger #14995

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix vscode debugger #14995

merged 2 commits into from
Nov 14, 2024

Conversation

RiskyMH
Copy link
Member

@RiskyMH RiskyMH commented Nov 5, 2024

What does this PR do?

The vscode debugger wasn't being enabled correctly unless using --inspect, as such things weren't working such as showing scoped variables.

How did you verify your code works?

manual testing

@robobun
Copy link

robobun commented Nov 5, 2024

@RiskyMH, your commit 8a03372 has 2 failures in #5728:

  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 14 x64
  • test/package.json - timeout on 🪟 2019 x64
  • @RiskyMH RiskyMH requested a review from Jarred-Sumner November 7, 2024 00:10
    @paperclover paperclover merged commit 3170b88 into main Nov 14, 2024
    23 of 25 checks passed
    @paperclover paperclover deleted the riskymh/debugger branch November 14, 2024 22:24
    snoglobe pushed a commit that referenced this pull request Nov 18, 2024
    snoglobe pushed a commit that referenced this pull request Nov 21, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants