fix vscode debugger #14995
Open
fix vscode debugger #14995
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @RiskyMH, your commit 1a9fd07 has 2 failures in test/js/bun/websocket/websocket-server.test.ts - 1 failing on 🪟 2019 x64-baselinetest/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 13 aarch64 |
| @@ -1854,7 +1854,7 @@ pub const VirtualMachine = struct { | |||
| }, | |||
| } | |||
|
|
|||
| if (debugger != .unspecified) { | |||
| if (this.debugger != null) { | |||
There was a problem hiding this comment.
Can you verify this doesn't cause us to start with the debugger enabled when it's not actively in use?
There was a problem hiding this comment.
I haven't managed to get any indication this is started unless using --inspect or the BUN_INSPECT env var.
It is hard to work out however because its the this.debugger = Debugger stage that starts the connection (with print).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The vscode debugger wasn't being enabled correctly unless using
--inspect, as such things weren't working such as showing scoped variables.How did you verify your code works?
manual testing