Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove checks for self closing tags #14990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ceymard
Copy link

@ceymard ceymard commented Nov 4, 2024

What does this PR do?

This fixes #14515 by simply stopping the checks with self-closing tags in jsx, as it should not be bun's responsibility to do so. I can update the tests, but I'm not familiar with the structure, can I just drop a jsx or tsx file in tests/snippets ?

This is just code removal and very little is touched in the .zig. The use case I give in #14515 passes.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
  • I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test-file-name.test)

@ceymard ceymard force-pushed the remove-jsx-self-closing-tags-checks branch from 0d0c625 to 0317919 Compare November 4, 2024 19:19
@ceymard ceymard force-pushed the remove-jsx-self-closing-tags-checks branch from 0317919 to 16dac36 Compare November 5, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<input> and <img> complain and crash if they are given children in JSX code, but shouldn't
1 participant