Changes expect().resolves.toThrow behaviour to more closely match jest

[pfgithub]

What does this PR do?

Fixes #14076

toThrow is for functions, like expect(() => {throw ...}).toThrow(), but jest also allows it to be used with resolves/rejects if the value is an error: expect(Promise.resolve(new Error("abc"))).resolves.toThrow("abc").

Previously, bun's implementation allowed any result to count as throwing, for example expect(Promise.resolve("abc")).resolves.toThrow("abc"). This updates bun:test to match jest and only count an Error result throwing.

• Documentation or TypeScript types (it's okay to leave the rest blank in this case)
• Code changes

How did you verify your code works?

• I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
• I included a test for the new code, or an existing test covers it
• N/A JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
• I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test-file-name.test)

[robobun]

❌ @pfgithub, your commit aef5c45 has 7 failures in #5545:

test/js/web/fetch/fetch-preconnect.test.ts - 1 failing on 🍎 aarch64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🍎 aarch64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🍎 aarch64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🪟 x64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🪟 x64-baseline

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 x64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 x64-baseline

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 x64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 x64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 x64-baseline

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 x64-baseline

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🪟 x64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🍎 x64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 aarch64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 aarch64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🐧 aarch64

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🪟 x64-baseline

test/js/node/test/parallel/crypto-webcrypto-aes-decrypt-tag-too-small.test.js - 1 failing on 🍎 x64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🪟 x64-baseline

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🪟 x64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🍎 aarch64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🍎 aarch64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 x64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 x64-baseline

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 x64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 x64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 x64-baseline

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 x64-baseline

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🪟 x64-baseline

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🪟 x64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 aarch64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 aarch64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 aarch64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🍎 x64

test/js/web/fetch/client-fetch.test.ts - 1 failing on 🍎 x64

test/cli/hot/hot.test.ts - 1 failing on 🪟 x64

test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64-baseline

test/js/bun/resolve/resolve.test.ts - 1 failing on 🪟 x64-baseline

test/js/bun/resolve/resolve.test.ts - 1 failing on 🪟 x64

test/js/bun/resolve/resolve.test.ts - 1 failing on 🪟 x64-baseline

test/js/bun/resolve/resolve.test.ts - 1 failing on 🪟 x64

test/cli/install/bun-patch.test.ts - 1 failing on 🍎 aarch64