Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net compatibility improvements #14933

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

net compatibility improvements #14933

wants to merge 34 commits into from

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented Nov 1, 2024 •
edited
Loading

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

CheckList:

Note: not all options in listen and connect are handled today.

Class: net.BlockList

  • blockList.addAddress(address[, type])
  • blockList.addRange(start, end[, type])
  • blockList.addSubnet(net, prefix[, type])
  • blockList.check(address[, type])
  • blockList.rules

Class: net.SocketAddress

  • new net.SocketAddress([options])
  • socketaddress.address
  • socketaddress.family
  • socketaddress.flowlabel
  • socketaddress.port

Class: net.Server

  • new net.Server([options][, connectionListener])
  • Event: 'close'
  • Event: 'connection'
  • Event: 'error'
  • Event: 'listening'
  • Event: 'drop'
  • server.address()
  • server.close([callback])
  • serverSymbol.asyncDispose
  • server.getConnections(callback)
  • server.listen()
  • server.listen(handle[, backlog][, callback])
  • server.listen(options[, callback])
  • server.listen(path[, backlog][, callback])
  • server.listen([port[, host[, backlog]]][, callback])
  • server.listening
  • server.maxConnections
  • server.ref()
  • server.unref()

Class: net.Socket

  • new net.Socket([options])
  • Event: 'close'
  • Event: 'connect'
  • Event: 'connectionAttempt'
  • Event: 'connectionAttemptFailed'
  • Event: 'connectionAttemptTimeout'
  • Event: 'data'
  • Event: 'drain'
  • Event: 'end'
  • Event: 'error'
  • Event: 'lookup'
  • Event: 'ready'
  • Event: 'timeout'
  • socket.address()
  • socket.autoSelectFamilyAttemptedAddresses
  • socket.bufferSize
  • socket.bytesRead
  • socket.bytesWritten
  • socket.connect()
  • socket.connect(options[, connectListener])
  • socket.connect(path[, connectListener])
  • socket.connect(port[, host][, connectListener])
  • socket.connecting
  • socket.destroy([error])
  • socket.destroyed
  • socket.destroySoon()
  • socket.end([data[, encoding]][, callback])
  • socket.localAddress
  • socket.localPort
  • socket.localFamily
  • socket.pause()
  • socket.pending
  • socket.ref()
  • socket.remoteAddress
  • socket.remoteFamily
  • socket.remotePort
  • socket.resetAndDestroy()
  • socket.resume()
  • socket.setEncoding([encoding])
  • socket.setKeepAlive([enable][, initialDelay])
  • socket.setNoDelay([noDelay])
  • socket.setTimeout(timeout[, callback])
  • socket.timeout
  • socket.unref()
  • socket.write(data[, encoding][, callback])
  • socket.readyState

Module:

  • net.connect()
  • net.connect(options[, connectListener])
  • net.connect(path[, connectListener])
  • net.connect(port[, host][, connectListener])
  • net.createConnection()
  • net.createConnection(options[, connectListener])
  • net.createConnection(path[, connectListener])
  • net.createConnection(port[, host][, connectListener])
  • net.createServer([options][, connectionListener])
  • net.getDefaultAutoSelectFamily()
  • net.setDefaultAutoSelectFamily(value)
  • net.getDefaultAutoSelectFamilyAttemptTimeout()
  • net.setDefaultAutoSelectFamilyAttemptTimeout(value)
  • net.isIP(input)
  • net.isIPv4(input)
  • net.isIPv6(input)

How did you verify your code works?

cirospaciari and others added 21 commits October 29, 2024 16:22
@robobun
Copy link

robobun commented Nov 1, 2024 •
edited
Loading

❌ @cirospaciari, your commit a400493 has 7 failures in #5633:

  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/net-local-address-port.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/zlib.test.js - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🍎 x64
  • test/js/node/test/parallel/net-sync-cork.test.js - 1 failing on 🍎 x64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🍎 x64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/net-socket-write-error.test.js - 1 failing on 🍎 x64
  • test/js/third_party/grpc-js/test-server.test.ts - 1 failing on 🍎 aarch64
  • test/js/third_party/grpc-js/test-server.test.ts - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🍎 aarch64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 x64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 x64-baseline
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🍎 x64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🍎 x64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 aarch64
  • test/js/node/test/parallel/http-eof-on-connect.test.js - 1 failing on 🐧 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 aarch64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🍎 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 x64-baseline
    		•

    @cirospaciari cirospaciari marked this pull request as ready for review November 1, 2024 00:35
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @cirospaciari @robobun @Jarred-Sumner