New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shell): add event loop task for `yes` #14916

Draft

dylan-conway wants to merge 1 commit into main from dylan/yes-task

Collaborator

dylan-conway commented Oct 30, 2024

What does this PR do?

Adds missing task for yes builtin.

How did you verify your code works?

Not sure how to test this other than spawning a process and checking for exit code 0.


          add yes task case

f523c5e

robobun commented Oct 30, 2024 •

edited

Loading

❌ @dylan-conway, your commit f523c5e has 4 failures in #5464:

test/regression/issue/ctrl-c.test.ts - illegal instruction at address 0x7ff81421537b on 🍎 x64

test/js/node/fs/fs.test.ts - 2 failing on 🐧 x64-baseline

test/v8/v8.test.ts - 20 failing on 🪟 x64-baseline

test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 aarch64

test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 aarch64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet