Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start fixing bugs discovered by Node.js's Node-API tests #14501

Draft
wants to merge 94 commits into
base: main
Choose a base branch
from

Conversation

190n
Copy link
Contributor

@190n 190n commented Oct 12, 2024

What does this PR do?

TODO before merging:

  • Get these tests running in CI
  • get other new tests to run from napi.test.ts
  • fix leak test
  • remove dependency on JSC change for napi_get_property_names (@heimskr)

Fixes #14336

Tests in js-native-api

  • 2_function_arguments/test.js
  • 3_callbacks/test.js
  • 4_object_factory/test.js
  • 5_function_factory/test.js
  • 6_object_wrap/test-object-wrap-ref.js
  • 6_object_wrap/test.js
  • 7_factory_wrap/test.js
  • 8_passing_wrapped/test.js
  • test_array/test.js
  • test_bigint/test.js
  • test_cannot_run_js/test.js
  • test_constructor/test.js
  • test_constructor/test2.js
  • test_constructor/test_null.js
  • test_conversions/test.js
  • test_dataview/test.js
  • test_date/test.js
  • test_error/test.js
  • test_exception/test.js
  • test_exception/testFinalizerException.js
  • test_finalizer/test.js
  • test_finalizer/test_fatal_finalize.js
  • test_function/test.js
  • test_general/test.js
  • test_general/testEnvCleanup.js
  • test_general/testFinalizer.js
  • test_general/testGlobals.js
  • test_general/testInstanceOf.js
  • test_general/testNapiRun.js
  • test_general/testNapiStatus.js
  • test_handle_scope/test.js
  • test_instance_data/test.js
  • test_new_target/test.js
  • test_number/test.js
  • test_number/test_null.js
  • test_object/test.js
  • test_object/test_exceptions.js
  • test_object/test_null.js
  • test_promise/test.js
  • test_properties/test.js
  • test_reference/test.js
  • test_reference/test_finalizer.js
  • test_reference_double_free/test.js
  • test_reference_double_free/test_wrap.js
  • test_string/test.js
  • test_string/test_null.js
  • test_symbol/test1.js
  • test_symbol/test2.js
  • test_symbol/test3.js
  • test_typedarray/test.js

How did you verify your code works?

Running Node's tests

@robobun
Copy link

robobun commented Oct 12, 2024

@heimskr, your commit 1c06dbd is building: #5655

@190n 190n changed the title Fix bugs discovered by Node.js's Node-API tests Start fixing bugs discovered by Node.js's Node-API tests Oct 16, 2024
@190n 190n marked this pull request as ready for review October 16, 2024 20:55
@190n 190n marked this pull request as draft October 17, 2024 16:29
heimskr and others added 30 commits October 31, 2024 20:54
This is so we can check the NAPI version per module and adjust behavior accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault | RakNet Module
6 participants