fix: delete user sessions when user is deleted in Clerk webhook - #284
Open
sureshchouksey8 wants to merge 2 commits into
Open
fix: delete user sessions when user is deleted in Clerk webhook#284sureshchouksey8 wants to merge 2 commits into
sureshchouksey8 wants to merge 2 commits into
Conversation
RudraMalvankar
left a comment
RudraMalvankar
left a comment
There was a problem hiding this comment.
Thanks for implementing the session cleanup on user.deleted; the approach looks straightforward. I noticed the PR also includes a number of unrelated formatting/refactoring changes alongside the functional fix. Would it be possible to keep this PR focused on the session deletion logic and move unrelated formatting changes into a separate PR? That would make the review much easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the TODO to delete all sessions for a user when a user.deleted webhook event is received from Clerk.