Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the changes to ROS2 #430

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Feb 4, 2025

Related Issues & PRs

Summary of Changes

  • Skip the lidar_scan based on a predefined percentage of the minimum number of valid columns in scan

Validation

  • Edit driver_params.yaml to set the sensor name and set min_scan_valid_columns_ratio value to a high value 0.9
  • Launch a node as usual ros2 ouster_ros driver.launch.py
  • Observe the warning messages whenever the number of valid columns drops below the set amount:
[ WARN] [1738283732.021510354]: number of valid columns per scan 160 which is below the ratio 90% SKIPPING SCAN
[ WARN] [1738283732.080962740]: number of valid columns per scan 304 which is below the ratio 90% SKIPPING SCAN

@Samahu Samahu marked this pull request as ready for review February 4, 2025 00:30
@Samahu Samahu merged commit 0f9a5be into ros2 Feb 4, 2025
10 checks passed
@Samahu Samahu deleted the ROS-268-min-valid-cols-lidar-scan-ros2 branch February 4, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants