Link pcap nodelet only if BUILD_PCAP is defined #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ovaag thanks for reporting the issue, somehow I can't reproduce the problem on my machine even though I made sure to clean the workspace and rebuilt with pcap off. But it does make sense to me to not include |
Samahu
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
When using current master with
BUILD_PCAPset to default valueOFFi got the following error:Summary of Changes
This seems to stem from that pcap_node is linked into the nodelets library regardless of the
BUILD_PCAPcmake argValidation
Tested on my robot with ouster lidar.
roslaunch ouster_ros sensor.launch <my_args>now runs as expected