Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS-227: Set LIDAR FOV on startup and add an option to persist the config [HUMBLE/IRON] #357

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Aug 20, 2024

Related Issues & PRs

Summary of Changes

  • Set LIDAR FOV on startup
  • Add an option to persist the config

Validation

  • Run the node with azimuth start and stop as follows
ros2 ouster_ros sensor.launch \
    azimuth_window_start:=150000 \
    azimuth_window_end:=250000

Verify that the azimuth window is cropped to selection

  • Run the node with persist_config set true as follows
ros2 ouster_ros sensor.launch.xml \
   <pass a selection of settings> \
    persist_config:=true

Verify that the new settings persist after power up/down cycle of the sensor

ALTERNATIVELY

  • Update the ros2 driver_params.yaml to set azimuth window start/end and the persist_config flag then launch the driver using:
ros2 launch ouster_ros driver.launch.py

Verify that the new settings persist after power up/down cycle of the sensor

@Samahu Samahu added the enhancement New feature or request label Aug 20, 2024
@Samahu Samahu self-assigned this Aug 20, 2024
@Samahu Samahu marked this pull request as ready for review August 21, 2024 20:02
@Samahu Samahu merged commit f81d515 into ros2 Aug 21, 2024
3 checks passed
@Samahu Samahu deleted the ROS-227-changing-lidar-fov-ros2 branch August 21, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant