Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2[HUMBLE/IRON] add pcap reader #355

Merged
merged 3 commits into from
Aug 15, 2024
Merged

ROS2[HUMBLE/IRON] add pcap reader #355

merged 3 commits into from
Aug 15, 2024

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Aug 15, 2024 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Implement a pcap reader nodelet
  • Pace scans by the packets timestamps
  • Conditionality enable and link the pcap library
  • Display progress

Validation

  • Enable PCAP_BUILD flag and build the driver then execute:
ros2 ouster_ros replay_pcap.launch.xml \
pcap_file:=... \
metadata:= ..

@Samahu Samahu added the enhancement New feature or request label Aug 15, 2024
@Samahu Samahu self-assigned this Aug 15, 2024
This was referenced Aug 15, 2024
Merged
Merged
@Samahu Samahu marked this pull request as ready for review August 15, 2024 16:30
twslankard
twslankard approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@twslankard twslankard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - same comments as the PR for Foxy.

matthew-lidar
matthew-lidar reviewed Aug 15, 2024
View reviewed changes
ouster-ros/CMakeLists.txt Outdated Show resolved Hide resolved
ouster-ros/src/os_pcap_node.cpp Show resolved Hide resolved
ouster-ros/src/os_pcap_node.cpp Show resolved Hide resolved
ouster-ros/src/os_pcap_node.cpp Outdated Show resolved Hide resolved
@Samahu Samahu merged commit f9f4590 into ros2 Aug 15, 2024
3 checks passed
@Samahu Samahu deleted the ros2-add-pcap-reader branch August 15, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-lidar matthew-lidar matthew-lidar left review comments

@twslankard twslankard twslankard approved these changes

@celentes celentes Awaiting requested review from celentes

@Krishtof-Korda Krishtof-Korda Awaiting requested review from Krishtof-Korda

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

@akatumalla-ouster akatumalla-ouster Awaiting requested review from akatumalla-ouster

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Samahu @twslankard @matthew-lidar