Skip to content

Commit

Permalink
formatting, require virtual base destructor to compile
Browse files Browse the repository at this point in the history
  • Loading branch information
Samahu committed Nov 8, 2023
1 parent 9007d1e commit e1a9da5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/os_driver_nodelet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace ouster_ros {
class OusterDriver : public OusterSensor {
public:
OusterDriver() : tf_bcast(getName()) {}
virtual ~OusterDriver() {
~OusterDriver() override {
NODELET_DEBUG("OusterDriver::~OusterDriver() called");
halt();
}
Expand Down
7 changes: 3 additions & 4 deletions src/os_sensor_nodelet.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ namespace ouster_ros {

class OusterSensor : public OusterSensorNodeletBase {
public:
~OusterSensor();
~OusterSensor() override;

void halt();

private:
virtual void onInit() override;

Expand All @@ -48,6 +46,8 @@ class OusterSensor : public OusterSensorNodeletBase {

virtual void on_imu_packet_msg(const uint8_t* raw_imu_packet);

void halt();

private:
std::string get_sensor_hostname();

Expand Down Expand Up @@ -80,7 +80,6 @@ class OusterSensor : public OusterSensorNodeletBase {

std::string load_config_file(const std::string& config_file);

private:
// fill in values that could not be parsed from metadata
void populate_metadata_defaults(sensor::sensor_info& info,
sensor::lidar_mode specified_lidar_mode);
Expand Down

0 comments on commit e1a9da5

Please sign in to comment.