Skip to content

Commit

Permalink
HOTFIX/ROS-376-initialize-the-sensor-with-launch-config-params (#380)
Browse files Browse the repository at this point in the history
* Invoke parse_config_from_ros_parameters on node init
* Fix a typo + Add a note regarding the recommendation
  • Loading branch information
Samahu authored Oct 3, 2024
1 parent 5dd8555 commit cd97df2
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Changelog
=========

ouster_ros v0.13.1
==================
* [BUGFIX]: Make sure to initialize the sensor with launch file parameters.

ouster_ros v0.13.0
==================
* [BUGFIX]: LaserScan is not properly aligned with generated point cloud
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release
> **Note**
> Specifying `Release` as the build type is important to have a reasonable performance of the driver.
> **Note**
> For ROS2 we recommend using **CycloneDDS** over **FastDDS**, through out Galactic, Foxy, Humble distros.
> **FastDDS** is usually the default ros middleware on most platforms, please follow the
[Guide](https://docs.ros.org/en/humble/Installation/DDS-Implementations/Working-with-Eclipse-CycloneDDS.html)
to learn how to enable **CycloneDDS** on your platform.
> We are yet to evaluate Zeonh performance against the ouster-ros driver for later distros.
Once the build succeeds, you must source the _install_ folder of your ros2 workspace to add launch
commands to your environment:
```bash
Expand Down
2 changes: 1 addition & 1 deletion ouster-ros/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>ouster_ros</name>
<version>0.13.0</version>
<version>0.13.1</version>
<description>Ouster ROS2 driver</description>
<maintainer email="[email protected]">ouster developers</maintainer>
<license file="LICENSE">BSD</license>
Expand Down
1 change: 1 addition & 0 deletions ouster-ros/src/os_sensor_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ OusterSensor::OusterSensor(const std::string& name,
change_state_client{
create_client<ChangeState>(get_name() + "/change_state"s)} {
declare_parameters();
staged_config = parse_config_from_ros_parameters();
attempt_reconnect = get_parameter("attempt_reconnect").as_bool();
dormant_period_between_reconnects =
get_parameter("dormant_period_between_reconnects").as_double();
Expand Down

0 comments on commit cd97df2

Please sign in to comment.