Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6774 Create invite_increase_notification mailer preview #5025

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amecreate
Copy link
Contributor

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6774

Purpose

Add mailer preview for the invite_increase_notification email.

Update the locale keys used in the mail to the current I18n standards.

Monkeypatch after_commit_everywhere to save the locale when deliver_after_commit is called (credit @Bilka2)

Testing Instructions

See Jira.

References

With the updated locale keys, Translation needs to move the keys in Phrase.

Credit

Amy Lee

end
end

if AfterCommitEverywhere::VERSION == "1.4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some Rubocop warnings on this file. You should fix the Layout/TrailingEmptyLines one.

The Rails/Output I think is actually fine. You can update Rubocop's rules from:

otwarchive/.rubocop.yml

Lines 155 to 158 in 8467810

Rails/Output:
Exclude:
# Allow migrations to print pt-osc comments to console:
- 'db/migrate/*.rb'

to:

Rails/Output:
  Exclude:
    # Allow patches to print warnings to console:
    - 'config/initializers/monkeypatches/*.rb'
    # Allow migrations to print pt-osc comments to console:
    - 'db/migrate/*.rb'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants