Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6872 Only notify creators when a work is added to a collection by an archivist #5024

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

marcus8448
Copy link

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6872

Purpose

Skips the attempt to notify creators when an archivist adds a non-work (a bookmark) to a collection.
Also adds a test to verify that a notification is still sent when a work is added to a collection by an archivist.

Testing Instructions

See instructions on the Jira issue.

References

N/A

Credit

marcus8448 (he/him)

Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Someone will be along to take care of Jira access soon if you've made an account.

In the meantime, I have a review comment: Could you create a test that makes sure that when an archivist adds a bookmark to a collection, there is no error like the one described on Jira and the bookmark is added to the collection?

And I follow "Add to Collections"
And I fill in "collection_names" with "ColdCollection"
And I press "Add"
Then 1 email should be delivered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a check for the email subject or text to make sure it's the right email?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI looks like #5023 is adding the same test for this mailer. Let's get that one merged first.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the test (as it is slightly tangential to the bug being fixed). If necessary, I can append a check for the email recipient and body to the test in #5023 after it is merged.

Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants